]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
inputMethod: Do not communicate preedit text change on reset
authorCarlos Garnacho <carlosg@gnome.org>
Fri, 29 Oct 2021 14:43:15 +0000 (16:43 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Mon, 1 Nov 2021 17:34:46 +0000 (18:34 +0100)
This is now done in the ClutterInputFocus for us, since
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1940. There
is no need to duplicate this call, and it happens to cause undesired
scrolling to content in some cases when this reset happens during
a change in the IM focused client state.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4647
(Cherry-picked from commit 047691b0d3471630ec80e32f371291dd2ef02419)

js/misc/inputMethod.js

index 7de7540d3f73e5e151d7c5c5f321e497f6efa1a1..71dff84f584747ebd6d1d49e8dcbe0c8f3017b60 100644 (file)
@@ -186,11 +186,7 @@ class InputMethod extends Clutter.InputMethod {
             this._emitRequestSurrounding();
         }
 
-        if (this._preeditStr !== null) {
-            // Unset any preedit text
-            this.set_preedit_text(null, 0, Clutter.PreeditResetMode.CLEAR);
-            this._preeditStr = null;
-        }
+        this._preeditStr = null;
     }
 
     vfunc_set_cursor_location(rect) {